search

dart-archive / dart2_fix

A tool to migrate API usage to Dart 2
https://pub.dartlang.org/packages/dart2_fix
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Tests failing on latest SDK #40

Open kevmoo opened 6 years ago

kevmoo commented 6 years ago

https://travis-ci.org/dart-lang/dart2_fix/builds/410955962

Are things broken on SDKs w/out the old constants, @devoncarew ?

devoncarew commented 6 years ago

Yes, looking at this:

Removing the deprecated constants from the SDK breaks both of those assumptions. We should update the docs for this tool to state that it can only be run on an sdk after the depreciations were introduced, and before the constants were removed.

kevmoo commented 6 years ago

...right. And set the SDK constraint and the travis config accordingly?

On Thu, Aug 2, 2018 at 6:23 AM Devon Carew notifications@github.com wrote:

Yes, looking at this:

  • we don't try and update code with analysis errors
  • we key off the places in code where the analysis server reports deprecation messages

Removing the deprecated constants from the SDK breaks both of those assumptions. We should update the docs for this tool to state that it can only be run on an sdk after the depreciations were introduced, and before the constants were removed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dart-lang/dart2_fix/issues/40#issuecomment-409924318, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCivLfYzsXBIU87aUTUvxh_WY7LGvCks5uMv08gaJpZM4VrjAa .

devoncarew commented 6 years ago

I updated the docs (https://github.com/dart-lang/dart2_fix/commit/98f083345bf21c69d4b2b67933420fdf5c1c65d1), but this is a sticky situation. We either need much longer deprecation periods, or our migration tools should be entirely regex based.