search

dart-archive / di.dart

DEPRECATED
https://webdev.dartlang.org/angular/guide/dependency-injection
MIT License
65 stars 57 forks source link

Di depends on dynamic version, even when static version is desired #171

Open alorenzen opened 10 years ago

alorenzen commented 10 years ago

Right now, src/module.dart imports relector_dynamic.dart, which in turn imports dart:mirrors. (https://github.com/angular/di.dart/blob/master/lib/src/module.dart#L6)

For using the static version of di, we should not depend on dart:mirrors.

Can we remove this dependency from the core code?

vicb commented 10 years ago

Isn't the reflector_dynamic import removed by the module transfomer ?

alorenzen commented 10 years ago

Ah, so it is. We haven't migrated to transformers yet, and are still using the generator script. This mentions a di_static.dart. Where is that generated?

vicb commented 10 years ago

We haven't migrated to transformers yet, and are still using the generator script

@alorenzen then you should discuss with @pavelgj I think this is what is has done in https://github.com/angular/di.dart/pull/169