search

dart-archive / di.dart

DEPRECATED
https://webdev.dartlang.org/angular/guide/dependency-injection
MIT License
66 stars 57 forks source link

feat: Add support for typedef #205

Closed vicb closed 8 years ago

vicb commented 9 years ago

@TedSander @rkirov @pavelgj I have tried to rebase #106 on latest master.

The tests are still failing in JS (dynamic injector) with Dart VM version: 1.8.3

Review on Reviewable

vicb commented 9 years ago

I have verified that dartbug.com/18938 has been fixed and is not the issue.

The JS issue has been fixed by the 2nd commit.

@pavelgj could you please review this PR ?

TedSander commented 9 years ago

Thanks Victor appreciate you running this down.

vicb commented 9 years ago

Also we need Dart >= 1.7 got this PR