search

dart-archive / di.dart

DEPRECATED
https://webdev.dartlang.org/angular/guide/dependency-injection
MIT License
65 stars 57 forks source link

Change checkBindArgs to use the equivalent method in smoke. #207

Closed jacob314 closed 7 years ago

jacob314 commented 9 years ago

Standardizing all calls to the smoke method will make it easier to generate optimized dart2js code for canAcceptNArgs some timein the near future.

Review on Reviewable

zoechi commented 9 years ago

Doesn't this need smoke in the pubspec.yamls transformers section to not use mirrors in JavaScript (the point of Smoke)?

jacob314 commented 9 years ago

These utility methods do not need a transformer. The current underlying implementation of the smoke method is identical to the existing code in di.dart.

On Thu, Jan 29, 2015 at 12:46 AM, Günter Zöchbauer <notifications@github.com

wrote:

Doesn't this need smoke in the pubspec.yamls transformers section to not use mirrors in JavaScript (the point of Smoke)?

— Reply to this email directly or view it on GitHub https://github.com/angular/di.dart/pull/207#issuecomment-71989160.