Dart editor collapse/expand icons disappeared

[DartBot]

Originally opened as https://github.com/dart-lang/sdk/issues/22986

This issue was originally filed by Jana.Moudr...@gmail.com

---

What steps will reproduce the problem? 1.Open some Dart code in Dart editor 2.See some method header - there is no collapse icon 3.Try Expand all/Collapse all - doesn't work

What version of the product are you using? Dart 1.9.1 (clear "installation")

On what operating system? Windows 7

Please provide any additional information below. See attached image

---

Attachment: dart-editor-bug.png (34.71 KB)

[DartBot]

Comment by whesse

---

This is verified on Windows stable, and on Linux stable. The checkbox to enable code folding is still there in preferences, and checking and unchecking it opens up and closes space on the left for the folding icons, but the icons do not appear, and clicking where they should be does nothing.

Will check on dev channel as well, to see when this started.

---

cc @danrubel. Added this to the 1.9 milestone. Removed Priority-Unassigned label. Added Priority-High, Area-Editor, Editor-Usability, Triaged labels.

[DartBot]

Comment by whesse

---

The problem exists as early as 1.9.0-dev.8.3

[DartBot]

Comment by whesse

---

No, the problem does not exist in 1.9.0-dev.8.3. The problem is sticky (sometimes), so that once you have run a version of the editor with the bug, the problem remains even when you run an earlier version of the editor. You must delete the ~/.dartEditor directory (on linux, see https://www.dartlang.org/tools/editor/troubleshoot.html#clear for other platforms) to get the expected behavior back again.

So, clearing the .dartEditor directory when needed, the problem occurs between 1.9.0-dev.10.0 and 1.9.0-dev.10.2. There is no linux build of the editor for 1.9.0-dev.10.1, but other platforms of dev.10.1 are at http://gsdview.appspot.com/dart-archive/channels/dev/raw/44252/editor/

The main thing that happened between these two versions is turning on the analysis server in the editor. I could not see if turning on the package root on 1.9.0-dev.10.0 would cause the problem because the editor crashed with a message "!MESSAGE To run analysis server from source, a package root must be supplied using -Dcom.google.dart.packageRoot.", and there was no package directory visible in the dart-sdk or elsewhere in the editor to set this property to.

[DartBot]

This comment was originally written by Jana.Mou...@gmail.com

---

Yesterday, when I downgraded back to 1.8.5 the only thing I had to do on Windows was to delete all Dart editor/sdk/etc... things in my Program Files (and replace them with older version). I didn't have to remove my User\DartEditor folder to make it work with 1.8.5.

[DartBot]

Comment by clayberg

---

Set owner to @scheglov. Removed this from the 1.9 milestone. Added this to the 1.10 milestone.

[DartBot]

Comment by clayberg

---

This is currently intentional behavior in 1.9 with the move to Analysis Server. Handling this well requires much better parser error recovery, so we will keep this open and revisit it in the future.

---

Removed this from the 1.10 milestone. Removed Priority-High label. Added Priority-Medium label.

[DartBot]

Comment by scheglov

---

OK, we should not display "Enable code folding" preference if it does not work. https://codereview.chromium.org/1002383004

[DartBot]

Comment by scheglov

---

https://code.google.com/p/dart/source/detail?r=44725

---

Removed the owner. Removed Priority-Medium label. Added Priority-Low label.