search

dart-archive / http_io

BSD 3-Clause "New" or "Revised" License
15 stars 15 forks source link

List<int> to Uint8List conversion #72

Closed tvolkert closed 5 years ago

tvolkert commented 5 years ago

This updates _CopyingBytesBuilder such that takeBytes() and toBytes() both declare a return type of Uint8List rather than List<int>.

This is in preparation for an SDK update whereby the API of BytesBuilder will receive the same update.

https://github.com/dart-lang/sdk/issues/36900

tvolkert commented 5 years ago

/cc @kevmoo (I can't add you as an official reviewer since I'm not a committer in this repo).

tvolkert commented 5 years ago

This unblocks https://dart-review.googlesource.com/c/sdk/+/101742 from landing

tvolkert commented 5 years ago

@kevmoo would you merge this for me too please?

tvolkert commented 5 years ago

(this is a forwards compatible change)