search

dart-archive / http_io

BSD 3-Clause "New" or "Revised" License
15 stars 15 forks source link

2 cleanup commits #77

Closed kevmoo closed 5 years ago

kevmoo commented 5 years ago

CC @tvolkert – won't get travis green, but it'll get it closer

kevmoo commented 5 years ago

@tvolkert – do you understand the failures? What's the deal w/ the Socket class?

tvolkert commented 5 years ago

Yeah, it's because of https://github.com/dart-lang/http_io/pull/75

tldr: this package is a synthetic package (not published to Pub), and the changes in https://github.com/dart-lang/http_io/pull/75 needed to land with failures before https://dart-review.googlesource.com/c/sdk/+/104524 in order for the SDK change to land.

tvolkert commented 5 years ago

Specifically, see https://dart-review.googlesource.com/c/sdk/+/104524/9/DEPS

kevmoo commented 5 years ago

ack

On Sun, Jul 7, 2019 at 11:52 AM Todd Volkert notifications@github.com wrote:

Specifically, see https://dart-review.googlesource.com/c/sdk/+/104524/9/DEPS

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dart-lang/http_io/pull/77?email_source=notifications&email_token=AAAEFCUEO4BTF436YGP3XFDP6I3NVA5CNFSM4H6WFIQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLRBAQ#issuecomment-509022338, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAEFCS44BGAH5OYHZ4HGPTP6I3NVANCNFSM4H6WFIQA .