search

dart-archive / http_io

BSD 3-Clause "New" or "Revised" License
15 stars 15 forks source link

Throw when adding to a closed sink? #9

Open kevmoo opened 6 years ago

kevmoo commented 6 years ago

https://github.com/dart-lang/http_io/blob/921d6bb5d0a01d8ac299569437b99c23f0ae577d/lib/src/http_impl.dart#L537

See https://github.com/dart-lang/sdk/issues/29554

Not sure what the plan is with https://codereview.chromium.org/2857393003

CC @floitschG

zanderso commented 6 years ago

l'll wait for input from Florian before doing anything with this, but my inclination is to remove the checks there and allow clients to hit the exception. I'd at least like to remove the references to stderr if nothing else is possible in the near future.