Make IsolateRunner.run generic to remove errors in dependent packages

[bwilkerson]

Sorry about the formatting churn! The only substantive change is on lines 187-188.

[kevmoo]

Rebase you change on top of my "strong" branch – enabling strong mode will light up a number of issues

On Thu, Sep 7, 2017 at 1:08 PM, Brian Wilkerson notifications@github.com wrote:

@bwilkerson commented on this pull request.

In lib/isolate_runner.dart https://github.com/dart-lang/isolate/pull/12#discussion_r137642599:

@@ -185,7 +184,8 @@ class IsolateRunner implements Runner { /// } finally { /// await iso.close(); /// }

• Future run(function(argument), argument, {Duration timeout, onTimeout()}) {

Not going to work...need to fix subclasses, too!

Where do I find the subclasses that need to be fixed?

Might want to build on #11 https://github.com/dart-lang/isolate/pull/11 – I enable strong mode checks, etc

If you think #11 https://github.com/dart-lang/isolate/pull/11 should land first, I have no problem with that. But I have no idea what "build on" means in this context.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dart-lang/isolate/pull/12#discussion_r137642599, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCirhfSksyuY-8AxBDnOylsWFpvFjBks5sgE0jgaJpZM4PQTl2 .

[kevmoo]

Digging around more, it seems that some serious refactoring is needed.

There are lots of methods with an optional callback.

So in so cases you need Future doThing(R returnValue()); In others Future doThingWithCallabck<P, R>(P returnValue(), R callback(P value));

Etc...

On Thu, Sep 7, 2017 at 1:26 PM, Kevin Moore kevmoo@google.com wrote:

Rebase you change on top of my "strong" branch – enabling strong mode will light up a number of issues

On Thu, Sep 7, 2017 at 1:08 PM, Brian Wilkerson notifications@github.com wrote:

@bwilkerson commented on this pull request.

In lib/isolate_runner.dart https://github.com/dart-lang/isolate/pull/12#discussion_r137642599:

@@ -185,7 +184,8 @@ class IsolateRunner implements Runner { /// } finally { /// await iso.close(); /// }

• Future run(function(argument), argument, {Duration timeout, onTimeout()}) {

Not going to work...need to fix subclasses, too!

Where do I find the subclasses that need to be fixed?

Might want to build on #11 https://github.com/dart-lang/isolate/pull/11 – I enable strong mode checks, etc

If you think #11 https://github.com/dart-lang/isolate/pull/11 should land first, I have no problem with that. But I have no idea what "build on" means in this context.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dart-lang/isolate/pull/12#discussion_r137642599, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCirhfSksyuY-8AxBDnOylsWFpvFjBks5sgE0jgaJpZM4PQTl2 .

[bwilkerson]

Can't push changes. Closing in order to re-create the branch.