search

dart-archive / isolate

Makes working with Dart isolates easier.
https://pub.dev/packages/isolate
BSD 3-Clause "New" or "Revised" License
90 stars 34 forks source link

enable null-safety #45

Closed 2ZeroSix closed 3 years ago

2ZeroSix commented 3 years ago

Closes #43

ericmartineau commented 3 years ago

Not sure if this will ever be merged. I released your branch as a project isolates. I'm happy to give you control, or git access. Thx for doing this

bsutton commented 3 years ago

@2ZeroSix @ericmartineau is the isolate project dead hence it won't be merged or is there some other reason it won't be?

I've found a bug in the isolates version of the code is there a github repo for it that I can push a patch to?

../../../.pub-cache/hosted/pub.dartlang.org/isolates-3.0.3+7/lib/isolate_runner.dart:85:36: Warning: Operand of null-aware operation '??' has type 'bool' which excludes null. isolate.setErrorsFatal(builder.failOnError ?? true);

2ZeroSix commented 3 years ago

FYI I haven't abandoned this pull request, I will have time to fix everything from the review comments in a few days

bsutton commented 3 years ago

@2ZeroSix any eta on getting this merged?

gaetschwartz commented 3 years ago

Hi, any updates in this PR ? Would be great if this could get merged or reviewed !

allanwolski commented 3 years ago

Thanks @2ZeroSix

I'm waiting for this too.

AlexV525 commented 3 years ago

@2ZeroSix Can you add me as a collaborator in your repo? I can push this forward as far as it can. We're currently waiting it for too long. :)

AlexV525 commented 3 years ago

Also I saw @Irhn said is investigating something like https://github.com/dart-lang/isolate/pull/45#discussion_r597514704 , any result?

AlexV525 commented 3 years ago

I've addressed all suggestions in this PR to #51 . FYI 😃