♻️ Migrate to non-nullable-by-default

dart-archive / isolate

Makes working with Dart isolates easier.

https://pub.dev/packages/isolate

BSD 3-Clause "New" or "Revised" License

90 stars 34 forks source link

♻️ Migrate to non-nullable-by-default #51

Closed AlexV525 closed 3 years ago

AlexV525 commented 3 years ago

Closes #43, continued from #45 .

The PriorityQueue has copied/pasted from the collection package.

AlexV525 commented 3 years ago

cc @lrhn if you wanna continue your review.

lrhn commented 3 years ago

Looks like util.dart needs to be formatted again, everything else looks good.

AlexV525 commented 3 years ago

Should be all good. Could you run checks again?

lrhn commented 3 years ago

Excellent. Thanks to @AlexV525 and @2ZeroSix for the migration. I'll take another pass at it, and see if I can improve the APIs before making a release.

2ZeroSix commented 3 years ago

@AlexV525 thanks for pushing it forward!

Unfortunately I had much less time to finish PR myself than I expected :disappointed:

AlexV525 commented 3 years ago

@AlexV525 thanks for pushing it forward!

Unfortunately I had much less time to finish PR myself than I expected 😞

Remember to update the AUTHORS since you've made the first part worked! 👍