clean up ChangeRecord API

dart-archive / observe

Support for marking objects as observable, and getting notifications when those objects are mutated

https://pub.dartlang.org/packages/observe

BSD 3-Clause "New" or "Revised" License

13 stars 6 forks source link

clean up ChangeRecord API #49

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

Issue by jmesserly Originally opened as dart-lang/sdk#14157

* Observable.changes should only be property changes.

ObservableList will have "listChanges" property which includes the ListChangeRecords.

Splitting this allows the consumer to know what kind of records it is getting, and makes the API constraints more clear.

* remove ChangeRecord base class

* add "target" to List/Map change record

* add old/new values to ListChangeRecord? See http://wiki.ecmascript.org/doku.php?id=harmony:observe#array.observe

DartBot commented 9 years ago

Comment by jmesserly

Removed this from the M8 milestone. Added this to the Later milestone.

DartBot commented 9 years ago

Comment by jmesserly

first step here: https://codereview.chromium.org/53743002/

Set owner to @jmesserly. Added Started label.

DartBot commented 9 years ago

Comment by jmesserly

Update: all issues are fixed except splitting out MapChangeRecord and adding "object" to it.

Removed the owner. Added Accepted label.

DartBot commented 9 years ago

Comment by sigmundch

Removed this from the Later milestone. Added this to the M9 milestone.

DartBot commented 9 years ago

Comment by clayberg

Removed this from the M9 milestone. Added this to the 1.1 milestone.

DartBot commented 9 years ago

Comment by sigmundch

Removed this from the 1.1 milestone. Added this to the 1.2 milestone.

DartBot commented 9 years ago

Comment by anders-sandholm

Removed Library-Observe label. Added Pkg-Observe label.

DartBot commented 9 years ago

Comment by jmesserly

Removed Area-Polymer label. Added Area-Pkg label.

DartBot commented 9 years ago

Comment by kasperl

Removed this from the 1.2 milestone. Added this to the 1.6 milestone.

DartBot commented 9 years ago

Comment by sigmundch

Removed Priority-Unassigned label. Added Priority-Low label.

DartBot commented 9 years ago

Comment by sigmundch

Removed this from the 1.6 milestone. Added Polymer-P-1 label.

DartBot commented 9 years ago

Comment by sigmundch

Removed Polymer-P-1 label. Added Polymer-Milestone-Next label.

DartBot commented 9 years ago

Comment by sigmundch

Removed Polymer-Milestone-Next label. Added PolymerMilestone-Next label.

DartBot commented 9 years ago

Comment by jmesserly

https://github.com/dart-lang/observe/issues/3

Added MovedToGithub label.