dart-archive / observe

Support for marking objects as observable, and getting notifications when those objects are mutated
https://pub.dartlang.org/packages/observe
BSD 3-Clause "New" or "Revised" License
13 stars 6 forks source link

Update onPropertyChange API docs for new notifyPropertyChange #50

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

Issue by sethladd Originally opened as dart-lang/sdk#14370


Concerning: http://api.dartlang.org/docs/releases/latest/observe.html#onPropertyChange

Currently it shows:

    _sub = onPropertyChange(_otherModel, #value,         () => notifyProperty(this, #prop);

But I think it should show:

     notifyPropertyChange(#prop, oldValue, newValue)

DartBot commented 9 years ago

Comment by sigmundch


Added this to the Later milestone.

DartBot commented 9 years ago

Comment by sigmundch


Removed this from the Later milestone. Added this to the M9 milestone.

DartBot commented 9 years ago

Comment by clayberg


Removed this from the M9 milestone. Added this to the 1.1 milestone.

DartBot commented 9 years ago

Comment by sigmundch


Removed this from the 1.1 milestone. Added this to the 1.2 milestone.

DartBot commented 9 years ago

Comment by sigmundch


Added Library-Observe label.

DartBot commented 9 years ago

Comment by anders-sandholm


Removed Library-Observe label. Added Pkg-Observe label.

DartBot commented 9 years ago

Comment by jmesserly


Removed Area-Polymer label. Added Area-Pkg label.

DartBot commented 9 years ago

Comment by kasperl


Removed this from the 1.2 milestone. Added this to the 1.6 milestone.

DartBot commented 9 years ago

Comment by kwalrath


Removed Type-Defect label. Added Type-Documentation label.

DartBot commented 9 years ago

Comment by sigmundch


https://codereview.chromium.org/368093004/


Set owner to @sigmundch. Added Started label.

DartBot commented 9 years ago

Comment by sigmundch


Removed Priority-Unassigned label. Added Priority-Low label.

DartBot commented 9 years ago

Comment by sigmundch


Removed this from the 1.6 milestone. Added Polymer-P-1 label.

DartBot commented 9 years ago

Comment by sigmundch


fixed in dart-lang/sdk@4cffed47e2733b897b115f718bf3e0410f5c6615


Added Fixed label.