search

dart-archive / observe

Support for marking objects as observable, and getting notifications when those objects are mutated
https://pub.dartlang.org/packages/observe
BSD 3-Clause "New" or "Revised" License
13 stars 6 forks source link

PathObserver is not correctly discarding changes #61

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

Issue by jmesserly Originally opened as dart-lang/sdk#18101

I don't see any logic in the "value" setter to prevent the change caused by the setter from being delivered. If it updated _value at least, that might work, but it doesn't

DartBot commented 9 years ago

Comment by jmesserly

Removed Area-Polymer label. Added Area-Pkg label.

DartBot commented 9 years ago

Comment by sigmundch

Added this to the 1.6 milestone. Removed Priority-Unassigned label. Added Priority-Medium label.

DartBot commented 9 years ago

Comment by sigmundch

Removed this from the 1.6 milestone. Added Polymer-P-1 label.

DartBot commented 9 years ago

Comment by sigmundch

John - was this addressed somehow by the fix you submitted last night?

DartBot commented 9 years ago

Comment by jmesserly

yup! set value no longer should discardChanges (semantically)

Added Fixed label.