Open whesse opened 8 years ago
Which bots are still trying to run on jsshell?
Under which heading is package-linux-collection?
If we are testing on firefox and the bot(s) are healthy then I think removing jsshell is OK. Otherwise we need coverage of jsshell or firefox.
Is this something that could be fixed by porting timer code from preambles/d8.js to preambles/jsshell.js?
I don't think it can be fixed, because there are just no non-zero timers available in jsshell. You would need to implement them with DateTime and polling, I think. I will remove the jsshell testing.
The bots running them are those without a .test_config file in the top-level directory of their package.
Bots like package-linux-collection try to run all the tests with jsshell, and this fails because jsshell does not support non-zero timers, and package:test uses them for its Invoker.heartbeat.
We should stop running package tests on jsshell, in my opinion, since all of them should be using package:test.
@nex3 @jakemac53