search

dart-archive / package-bots

Scripts specifying what to run in the package waterfall client.dart.packages.
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Windows bots pub upgrade error - works fine locally #5

Open jakemac53 opened 9 years ago

jakemac53 commented 9 years ago

see http://chromegw.corp.google.com/i/client.dart.packages/builders/packages-windows-paper-elements/builds/307/steps/annotated_steps/logs/stdio

jakemac53 commented 9 years ago

looks like both pub upgrade and pub build are having issues finding some files

jakemac53 commented 9 years ago

cc @ricowind

ricowind commented 9 years ago

cc @sigmundch : this seems like a pub problem right?

sigmundch commented 9 years ago

Not sure - it could be. It could also be a cache corruption issue in our cleanup in the bots. For example, recall in the past when we had a recursive delete command that was deleting inside the symlinked package folders. I thought we fixed that, but it could be something similar?

ricowind commented 9 years ago

So I guess we have two choices: -- live with the failures that our customers are also seeing -- run with a clean cache

I vote for the first since otherwise we will never take the time to debug this.

The next time we see this we should debug it on the bot!

Cheers, Rico

On Thu, Apr 9, 2015 at 6:23 PM, sigmundch notifications@github.com wrote:

Not sure - it could be. It could also be a cache corruption issue in our cleanup in the bots. For example, recall in the past when we had a recursive delete command that was deleting inside the symlinked package folders. I thought we fixed that, but it could be something similar?

— Reply to this email directly or view it on GitHub https://github.com/dart-lang/package-bots/issues/5#issuecomment-91280186 .

sigmundch commented 9 years ago

Yeah - agree. I think some bots right now have the failures, so we should look into it (or manually fix the cache once today, and look into it again on a fresh failure next time it fails)

jakemac53 commented 9 years ago

It seems to happen consistently for the paper_elements package

ricowind commented 9 years ago

Siggi has access to log into the bot if you want to take a closer look at the contents of the pub cache

Cheers, Rico

On Thu, Apr 9, 2015 at 6:48 PM, Jacob MacDonald notifications@github.com wrote:

It seems to happen consistently for the paper_elements package

— Reply to this email directly or view it on GitHub https://github.com/dart-lang/package-bots/issues/5#issuecomment-91288379 .

sigmundch commented 9 years ago

Ok, we have one theory, it seems that we still use the rmtree in one place here where we clean up the tmp folder.

ricowind commented 9 years ago

That is a good theory, we should just change that to use the SafeDelete

Cheers, Rico

On Thu, Apr 9, 2015 at 6:59 PM, sigmundch notifications@github.com wrote:

Ok, we have one theory, it seems that we still use the rmtree in one place here https://github.com/dart-lang/package-bots/blob/master/annotated_steps.py#L114 where we clean up the tmp folder.

— Reply to this email directly or view it on GitHub https://github.com/dart-lang/package-bots/issues/5#issuecomment-91290828 .

sigmundch commented 9 years ago

never mind - that code is unreachable :(

ricowind commented 9 years ago

I will then change my response: We should change that code to the empty string

On Thu, Apr 9, 2015 at 7:00 PM, sigmundch notifications@github.com wrote:

never mind - that code is unreachable :(

— Reply to this email directly or view it on GitHub https://github.com/dart-lang/package-bots/issues/5#issuecomment-91291376 .

sigmundch commented 9 years ago

+1 :)

OK, we logged into the bots and now we know what the issue is: the path names were too long! Noooooo!!!

So we probably need similar fixes like @whesse did in the normal Dart repo.

jakemac53 commented 9 years ago

http://bit.ly/1HVJkxS