search

dart-archive / polymer-dart

Polymer support for Dart
https://pub.dartlang.org/packages/polymer
BSD 3-Clause "New" or "Revised" License
181 stars 33 forks source link

Use excludeOverriden in the query options when creating a JS proxy #532

Closed donny-dont closed 9 years ago

donny-dont commented 9 years ago

Fixes #531

donny-dont commented 9 years ago

Just a heads up this test is failing before and after this particular commit. Everything else is passing.

00:02 +8 -1: test\src\common\polymer_descriptor_test.dart: can build polymer descriptor objects
  type 'JsFunctionImpl' is not a subtype of type '(dynamic) => bool' of 'f'.
  package:matcher/src/core_matchers.dart 571:24  predicate
  package:matcher/src/util.dart 42:12            wrapMatcher
  package:test                                   expect
  polymer_descriptor_test.dart 135:5             expectEqual
  polymer_descriptor_test.dart 129:3             expectProperty
  polymer_descriptor_test.dart 33:5              main.<async>.<fn>
jakemac53 commented 9 years ago

lgtm, thanks!

donny-dont commented 9 years ago

Thank you for merge :+1:

Onto the next 1.0 issue!