search

dart-archive / polymer-dart

Polymer support for Dart
https://pub.dartlang.org/packages/polymer
BSD 3-Clause "New" or "Revised" License
180 stars 33 forks source link

Behaviors! #557

Closed jakemac53 closed 9 years ago

sigmundch commented 9 years ago

Looks good! To make it easier for me to see things clearly, I copied your PR into rietveld and added comments here: https://codereview.chromium.org/1290643006/

jakemac53 commented 9 years ago

@sigmundch Update here, but I think you will have to push the changes to reitveld? I also fully flushed out the tests and fixed the js behavior properties issue.

sigmundch commented 9 years ago

added a few more nit comments, but otherwise lgtm

jakemac53 commented 9 years ago

this has been merged into the behavior branch, closing