search

dart-archive / polymer-dart

Polymer support for Dart
https://pub.dartlang.org/packages/polymer
BSD 3-Clause "New" or "Revised" License
181 stars 33 forks source link

Create Polymer 1.0 elements automatically #657

Closed eloypastor closed 8 years ago

eloypastor commented 8 years ago

Create Polymer 1.0 elements automatically. See: https://github.com/dart-lang/polymer-dart/wiki/feature-overview

eloypastor commented 8 years ago

Yes, but feature-overview and the main-app.html file created automatically for new Polymer projects in Webstorm don't put the style inside the template. I hope thi is the right way.

dam0vm3nt commented 8 years ago

right, that should by pointed out too to @jakemac53 ... I think the polymer docs are the more up to date WRT this topic.

eloypastor commented 8 years ago

In Polymer doc you can read:

Note : Prior to Polymer 1.1, the recommendation was to place <style> tags inside the <dom-module> for an element (but outside the <template>). This is still supported, but is no longer recommended.

So you're right. <style> must be inside <template>.

Thanks!

jakemac53 commented 8 years ago

Also I just set up the 1.0.0-rc.10 branch, would you mind creating a new PR which is going to be merged into that branch (1.0.0-rc.9 is already released). I don't think you can change it once a PR is created unfortunately.

jakemac53 commented 8 years ago

closing in favor of https://github.com/dart-lang/polymer-dart/pull/658