search

dart-archive / polymer_elements

https://pub.dartlang.org/packages/polymer_elements
BSD 3-Clause "New" or "Revised" License
24 stars 17 forks source link

Noticed *.test files are being included in build #129

Open terrywarwar opened 8 years ago

terrywarwar commented 8 years ago

Noticed "*.test" files being included in build. Can these be removed also when doing a release build. Is there anyway to build and deploy only the files needed by the user?

/build/web/packages/polymer_elements/src/prism/tests/languages/yaml/null_feature.test
/build/web/packages/polymer_elements/src/prism/tests/languages/yaml/number_feature.test
/build/web/packages/polymer_elements/src/prism/tests/languages/yaml/scalar_feature.test
/build/web/packages/polymer_elements/src/prism/tests/languages/yaml/string_feature.test
/build/web/packages/polymer_elements/src/prism/tests/languages/yaml/tag_feature.test
...
jakemac53 commented 8 years ago

We can exclude files which are never necessary (such as these), but we don't have a way today of treeshaking only the files which are needed. It is pretty much impossible unfortunately since you could dynamically add css files or html imports in your code, and its not realistic to try and track that.

jakemac53 commented 8 years ago

Also it should be noted all these extra files will only be deployed to your server, not the end user, so the impact is relatively minimal.

terrywarwar commented 8 years ago

I can see that the paper_elements used in the application are included the build index.html including the comments. Do these files need to also be deployed?