search

dart-archive / rules_dart

Dart rules for Bazel
Apache License 2.0
12 stars 17 forks source link

Document the rules in an md file #161

Open tvolkert opened 7 years ago

tvolkert commented 7 years ago

For example, check out the docs for apple rules at https://github.com/bazelbuild/rules_apple/blob/master/doc/rules-ios.md#ios_application

natebosch commented 7 years ago

We should see if https://github.com/bazelbuild/skydoc works on these rules.

Definitely open to adding this if someone has time to try it out and send a PR.

marcguilera commented 6 years ago

I'm a bit lost with this package and improving documentation would help big time 👍

What is wrong with this set up?

Workspace:

# Dart
git_repository(
    name = "rules_dart",
    remote = "https://github.com/dart-lang/rules_dart.git",
    tag = "v0.4.9",
)
load("@rules_dart//dart/build_rules:repositories.bzl", "dart_repositories")
dart_repositories()

A barebone build:

load("@rules_dart//dart/build_rules:core.bzl", "dart_library")
package(default_visibility = ["//visibility:public"])

I am getting an error on build:

ERROR: /private/var/tmp/_bazel_marcguilera/10b327fd9d5413a300b42a0aa4f3edb4/external/rules_dart/dart/build_rules/internal/dart_library.bzl:25:20: name 'set' is not defined
ERROR: error loading package 'libs': Extension 'dart/build_rules/internal/dart_library.bzl' has errors
INFO: Elapsed time: 0.061s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
    currently loading: libs

Another question I have is how does one import external dependencies from pub to projects?

natebosch commented 6 years ago

I am getting an error on build: name 'set' is not defined

We're not actively supporting these rules, so I can't guarantee they'll work today.

However the particular bug you're hitting was fixed in https://github.com/dart-lang/rules_dart/pull/170 and you've got an old version.