Include forced_deps in .packages file

dart-archive / rules_dart

Dart rules for Bazel

Apache License 2.0

12 stars 17 forks source link

Closed natebosch closed 6 years ago

natebosch commented 6 years ago

When a target is included in forced_deps but not deps it won't show up in the .packages file so package: URIs can't resolve it.

Pass through the label_list to codegen_action and filter later
Pass forced_deps to _package_map_tmp_file and append it's location. If the same target shows up in both deps and forced_deps it will show up twice in the file, but this should be safe since they'll have the same location.

natebosch commented 6 years ago

cc @nshahan - this should resolve your issue. For now you can add the dep to both deps and forced_deps as a workaround.

nshahan commented 6 years ago

Thanks for the quick fix. I'll keep working with the workaround for now.

natebosch commented 6 years ago

Thank you @nshahan for narrowing down the issue to the .packages file!