dart-archive / smoke

Smoke is a Dart package that exposes a reduced reflective system API. This API includes accessing objects in a dynamic fashion (read properties, write properties, and call methods), inspecting types (for example, whether a method exists), and symbol/string convention.
https://pub.dartlang.org/packages/smoke
BSD 3-Clause "New" or "Revised" License
12 stars 3 forks source link

[smoke] compareList(unordered: true) is broken #12

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

Issue by vicb Originally opened as dart-lang/sdk#19471


The unordered comparison is broken in common.dart:

    var bSet = new Set()..addAll(b);     for (int i = 0; i < a.length; i++) {       if (!bSet.contains(a[i])) return false;     }

if a=[1, 1, 1] and b = [1, 2, 3] it will return true.

DartBot commented 9 years ago

Comment by kasperl


Added Area-Pkg, Pkg-Smoke, Triaged labels.

DartBot commented 9 years ago

Comment by sigmundch


fix out for review https://codereview.chromium.org/370493002/


Added this to the 1.6 milestone. Removed Priority-Unassigned label. Added Priority-Medium label.

DartBot commented 9 years ago

Comment by sigmundch


Removed this from the 1.6 milestone. Added Polymer-P-1 label.

DartBot commented 9 years ago

Comment by sigmundch


Removed Polymer-P-1 label. Added Polymer-Milestone-Next label.

DartBot commented 9 years ago

Comment by sigmundch


Added PolymerMilestone-Next label.

DartBot commented 9 years ago

Comment by sigmundch


Removed Polymer-Milestone-Next label.

DartBot commented 9 years ago

Comment by vicb


Seems like the code is still broken (I've left a comment in the review)

DartBot commented 9 years ago

Comment by sigmundch


Added Fixed label.