search

dart-archive / stagehand

Dart project generator - web apps, console apps, servers, and more.
https://pub.dev/packages/stagehand
BSD 3-Clause "New" or "Revised" License
649 stars 118 forks source link

Migrate web-simple template to null-safety #699

Closed matsp closed 3 years ago

matsp commented 3 years ago

Just stumpled over it while testing some ideas.

devoncarew commented 3 years ago

I haven't reviewed this, but this null safe change wasn't already captured in https://github.com/dart-lang/stagehand/pull/696?

matsp commented 3 years ago

Nope. All web templates are affected. If it helps you I can also check the other two.

EDIT: Checked the other two templates - they can't be upgraded yet due not null-safety aware dependencies.

devoncarew commented 3 years ago

Thanks! I added two reviewers; if we need these changes, we should be sure to also apply them to the copy in dart-lang/sdk.

devoncarew commented 3 years ago

This will update the sdk version: https://dart-review.googlesource.com/c/sdk/+/194106.