search

dart-archive / stagehand

Dart project generator - web apps, console apps, servers, and more.
https://pub.dev/packages/stagehand
BSD 3-Clause "New" or "Revised" License
648 stars 118 forks source link

Discontinue package #704

Closed mit-mit closed 3 years ago

mit-mit commented 3 years ago

Fixes https://github.com/dart-lang/stagehand/issues/671

mit-mit commented 3 years ago

cc @devoncarew @domesticmouse not entirely sure how to version this. Should it actually be 5.0.0?

devoncarew commented 3 years ago

cc @devoncarew @domesticmouse not entirely sure how to version this. Should it actually be 5.0.0?

Good question. My guess is that v4.0.0 is that last non-deprecated version that we want people to use, and v5.0.0 is the version where we deprecate? cc @natebosch

natebosch commented 3 years ago

In my opinion deprecating in the current major version is sensible.

I don't know if we have prior experience adding a deprecation warning to a pub global activate tool.

domesticmouse commented 3 years ago

From the logs, please run pub run build_runner build to update the stashed version number.

mit-mit commented 3 years ago

@domesticmouse yes, will do.

From an offline discussion with @devoncarew, I'm planning on updating this to be say that Stagehand is "Discontinued", not just deprecated. For the tools that are in the SDK, it makes sense to go through a two step process first deprecating then discontinuing, as discontinuing means the tool is no longer in the SDK. For stagehand, it will be on pub.dev marked discontinued, but you can still run the tool.

WDYT?

mit-mit commented 3 years ago

Current build failure seems to also be happening on the master branch: https://github.com/dart-lang/stagehand/runs/2658002053

mit-mit commented 3 years ago

@domesticmouse @devoncarew can you please re-review as this changed substantially?

domesticmouse commented 3 years ago

Still LGTM, no idea why the build is breaking. @kevmoo might have some insights.

mit-mit commented 3 years ago

Given the build is already broken on master, I'm going to merge.

mit-mit commented 3 years ago

@domesticmouse can you please publish? I don't seem to have permissions.

domesticmouse commented 3 years ago

Published