Fixes to t2dart to make it run within Google

dart-archive / ts2dart

ts2dart TypeScript to Dart transpiler

Apache License 2.0

181 stars 62 forks source link

Fixes to t2dart to make it run within Google #310

Closed vikerman closed 8 years ago

vikerman commented 8 years ago

Upstreaming local Google changes to public github repository.

ts2dart should now handle relative path names as input and basePath. Fixed tests accordingly.
Removed inlined fs-extra code and switched to using our own mkdirP implementation.
Also fixed some bugs with mkdirP.

vikerman commented 8 years ago

I changed to use basePath without the cwd. Also added test case to cover all combinations of the input file paths and destination directory being relative and absolute.

Changed mkdirP to the way you suggested.

mprobst commented 8 years ago

@rkirov could you review this? I'm stuck in an infinite meeting.

rkirov commented 8 years ago

looks good, just explain the resolve/relative dance.