search

dart-archive / ts2dart

ts2dart TypeScript to Dart transpiler
Apache License 2.0
180 stars 61 forks source link

feat(filesystem): Apply basePath to relative input TS files and library names #320

Closed vikerman closed 8 years ago

vikerman commented 8 years ago

Doesn't change module file name resolution

vikerman commented 8 years ago

Tested with angular/angular that the code generated with and without the change are the same.

alexeagle commented 8 years ago

This is okay with me, but it really needs some tests that fail before the change. Can we find the right fixture for a test that reproduces the path problems? I'm imagining a test that lays out a temp directory that looks similar to the google3 scenario, and maybe another that's layed out like angular/angular, and asserts that the program can run on trivially simple inputs.

We could do that in a follow-up change so we're not blocked on google3/ts2dart.

alexeagle commented 8 years ago

LGTM