search

dart-archive / ts2dart

ts2dart TypeScript to Dart transpiler
Apache License 2.0
180 stars 61 forks source link

fix(): add a lenientTypingFileCheck option to only check the end of the path #344

Closed hansl closed 8 years ago

mprobst commented 8 years ago

This seems a bit dangerous. What's the problem that you're actually trying to solve? Maybe there's a solution that's on a slightly higher semantic level, e.g. search with or without node_modules?

I think the name of the feature is also quite misleading, maybe matchFullFacadePath: false is more speaking?

hansl commented 8 years ago

This is bad in general, I agree with you. After talking with Alex I'm going to come up with a typingsRoot argument instead.