Closed matsko closed 8 years ago
A couple of nits left, but overall LGTMs.
Please clean up the tests, there's a lot of duplication in them that doesn't test anything that's not covered by other tests already.
Merged as ac5ac86, 97197d7.
A couple of nits left, but overall LGTMs.
Please clean up the tests, there's a lot of duplication in them that doesn't test anything that's not covered by other tests already.