search

dart-archive / vm_service_client

A Darty client for the VM service protocol
https://pub.dev/packages/vm_service_client
BSD 3-Clause "New" or "Revised" License
12 stars 19 forks source link

Add VMStep.OverAsyncSuspension and atAsyncSuspension #33

Closed DanTup closed 6 years ago

DanTup commented 6 years ago

This fixes #30 and #31.

I used the Over test as a template and just made it async; let me know if I can do better. I wasn't totally sure what this code was doing in the Over test:

stdout.next.then(neverCalled).catchError((_) {});

So I didn't include it. It seems like it'll throw on the next output, but then swallow the error; but that seems pointless. LMK what it's actually doing and whether I should have something similar.

I had to do this work against a slightly older SDK (I used v2 dev40) because the tests all time out in the newest versions and I couldn't totally figure out why. I can't see any obvious CI set up here so if it's building somewhere and this fails (I don't expect it to, it passes locally) let me know.

jacob314 commented 6 years ago

Please also update the changelog and modify the version number. It would be fine to only perform one version update for both this CL and your other pending CL to vm_service_client.

DanTup commented 6 years ago

Addressed the comments and updated changelog/version.

I'll update the version to the same in the other PR and rebase whichever PR comes last and merge together (I didn't want to add the other PRs changes to the changelog here as that seemed a bit weird).

DanTup commented 6 years ago

(btw, someone will need to merge this when happy with it as I don't have merge permissions here)

DanTup commented 6 years ago

I've rebased on master since the version number I used has been used now and also fixed a minor formatting issue that made Travis red.