dart-archive / vm_service_client

A Darty client for the VM service protocol
https://pub.dev/packages/vm_service_client
BSD 3-Clause "New" or "Revised" License
12 stars 19 forks source link

Add support for `getSourceReport` - now final #6

Closed kevmoo closed 8 years ago

kevmoo commented 8 years ago

The VM Service has now added a stable getSourceReport API – it was added at some point in 1.16 SDK

Would be good to expose this API in this package.

nex3 commented 8 years ago

@johnmccutchan @turnidge: What version of the VM service protocol first included this method? Did it come with any additional methods? There isn't any documentation of this either in the SDK changelog or in the service protocol revision history.

kevmoo commented 8 years ago

Looks like it was added in 3.1 - see here https://github.com/dart-lang/sdk/commit/bf385e448c30323d68524df99f7329174f70ceef

kevmoo commented 8 years ago

https://codereview.chromium.org/1929063002/

pulyaevskiy commented 8 years ago

Wondering if this can be prioritized? This may seem like a low priority but a lot of community package builds are broken because of this and coverage package.