Transformer breaks on name with dashes

dart-archive / web-components

Dart package providing the web components platform polyfills

https://pub.dartlang.org/packages/web_components

BSD 3-Clause "New" or "Revised" License

18 stars 10 forks source link

Transformer breaks on name with dashes #36

Closed flash1293 closed 8 years ago

flash1293 commented 8 years ago

pub build breaks if I use the web_components-transformer and a name with a dash in pubspec.yaml

Steps to reproduce:

check out https://github.com/flash1293/polymer_dart_example
pub get
pub build - succeeds
Change name: in pubspec.yaml to polymer-dart-example or something
pub build
[Error from WebComponents on polymer-dart_example|web/foo.html]: Could not load asset polymer-dart_example|web/foo.dart

jakemac53 commented 8 years ago

Interesting, for what its worth in general dart packages follow the underscore pattern (which is why this hasn't come up before). It should probably still work with dashes though ;)

jakemac53 commented 8 years ago

Just fyi, we decided to not actually add support for this but instead surface a better error.