search

dart-archive / web-components

Dart package providing the web components platform polyfills
https://pub.dartlang.org/packages/web_components
BSD 3-Clause "New" or "Revised" License
18 stars 10 forks source link

support hyphens in package names #37

Closed jakemac53 closed 8 years ago

jakemac53 commented 8 years ago

closes https://github.com/dart-lang/web-components/issues/36

sigmundch commented 8 years ago

technically lgtm, but let's hear what @munificent has to say.

munificent commented 8 years ago

@jakemac53 and I talked about it over lunch. Like @sigmundch notes, pub makes this restriction in the hopes that we can take advantage of it to get better import syntax. I'd really hate to abandon that.

Ideally, we'd make package names like this an eagerly detected error in pub, but that would be a breaking change at this point. (And a breaking change with little end user value today since it's not like we have better import syntax yet.)

Given that, the safest thing to do is to have Polymer detect this error and report it.

jakemac53 commented 8 years ago

@sigmundch updated to throw an error instead

sigmundch commented 8 years ago

lgtm!