Bouncing Balls fails to load

[srawlins]

The Bouncing Balls sample fails to load: https://www.dartlang.org/samples/bouncing_balls/example/packages/browser/dart.js returns 404.

CC @sethladd @kwalrath

[d2m]

Installed 'link-checker' gem and ran through the /samples folder

Two errors besides the missing .js file:

Problem: build/static/samples/bouncing_balls/index.html Link: https://github.com/angular/angular.dart/tree/master/example/web/bouncing_balls

Problem: build/static/samples/notifications/index.html Link: https://github.com/dart-lang/dart-samples/tree/master/html5/web/notifications/quick

Also found that 4 examples are not included in the /samples folder but referenced from code.google.com, maybe we should bring them in?

Problem: build/static/samples/index.html Link: https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/samples/searchable_list Link: https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/samples/gauge Link: https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/samples/dgrep Link: https://code.google.com/p/dart/source/browse/branches/bleeding_edge/dart/samples/google_maps

(code.google.com is a bit allergic to linkcheckers ;)

[kwalrath]

@Sfshaza could you take a look? I don't know how long it's been broken or why it broke, but it's probably an include problem.

@shailen feel free to take over if you have the bandwidth. I suspect we'll err on the side of having fewer samples, rather than more, but we should be explicit about this decision.

[sethladd]

What can we do in a build step to check things? The bummer is that we don't know when samples fail to load. Can we be proactive with the checking?

[kwalrath]

Could we do 404 tracking of some type?

[sethladd]

Sure. Also, how about running pub build for all the samples for a deploy build?

[Sfshaza]

I will look at it.

On Sun, Sep 14, 2014 at 11:58 AM, Seth Ladd notifications@github.com wrote:

Sure. Also, how about running pub build for all the samples for a deploy build?

— Reply to this email directly or view it on GitHub https://github.com/dart-lang/www.dartlang.org/issues/1033#issuecomment-55535468 .

[kwalrath]

One thing that's happened in the past is someone confirms the app runs in their repo, and they deploy from their repo, but they don't remember to exempt their app's packages directory (for instance) from .gitignore.

The next time someone pushes from another repo, the app breaks because the packages directory is missing.

One fix would be to auto-publish from a bot, AND to check the newly posted site to make sure the app works.

A similar fix would be for everyone to, ahem, publish from a clean repo kept only for publishing AND to check the newly posted site.

Still, some sort of coalesced 404 reporting would be helpful, and real tests you can easily run on both local and running sites would of course be awesome.

[shailen]

This sample has been removed from dartlang.org/samples. I recommend closing the bug.

[kwalrath]

We should also remove/fix any files related to the removed samples, so they won't show up the next time we run a link checker.

On Mon, Sep 15, 2014 at 3:30 PM, Shailen Tuli notifications@github.com wrote:

This sample has been removed from dartlang.org/samples. I recommend closing the bug.

— Reply to this email directly or view it on GitHub https://github.com/dart-lang/www.dartlang.org/issues/1033#issuecomment-55669022 .

[kwalrath]

@Sfshaza, are the files pointing to the removed samples actually in the github repo, or are they just leftovers from moldy personal repos?

[Sfshaza]

The bouncing_balls and notifications examples are not working but are also not being used. I've removed both from the repo. (That's all I did for this CL.)