search

dart-atom / dart

A Dart plugin for Atom.
http://dart-atom.github.io/dart/
BSD 3-Clause "New" or "Revised" License
154 stars 44 forks source link

Function.extractParams is deprecated. #1107

Open jacehensley-wf opened 7 years ago

jacehensley-wf commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/Applications/Atom Beta.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/text-editor.js:1753:38)
JsObject.callMethod$2 (/Users/jacehensley/.atom/packages/dartlang/web/entry.dart.js:46319:44)
TextEditor.invoke$4 (/Users/jacehensley/.atom/packages/dartlang/web/entry.dart.js:49250:27)
zakwanhaj commented 7 years ago

+1

djcohen66 commented 7 years ago

+2

devoncarew commented 7 years ago

@jacehensley-wf, can you provide a link to the deprecated part of the API? Looking here: https://atom.io/docs/api/v1.19.1/TextEditor#instance-markBufferRange, I don't see what's deprecated. Thanks!

jacehensley-wf commented 7 years ago

Oh man I don't even know, this was all generated by Atom. I just clicked "Create new issue" when the message popped up.