search

dart-atom / dart

A Dart plugin for Atom.
http://dart-atom.github.io/dart/
BSD 3-Clause "New" or "Revised" License
154 stars 44 forks source link

Add Configuration Options For Max Warnings Per File and Project #1111

Closed jacehensley-wf closed 7 years ago

jacehensley-wf commented 7 years ago

Proposed solution for https://github.com/dart-atom/dartlang/issues/940.

How It Was Fixed:

  • Add configuration options for maxIssuesPerFile and maxIssuesPerProject.
  • Had to bump the order of the options after that.
  • Change the const variables _maxIssuesPerFile and _maxIssuesPerProject to be getters.
  • They can no longer be const because they can be updated.
  • Use the values from the configuration options in the getters.

    Testing Suggestions:

  • Pull down this branch:
  • See that you can change the max issues displayed per project and file.
  • Change them.
  • Run Reanalyze Sources
  • Create enough errors that they get truncated by the max values.
  • See that get get truncated at the provided values.

FYA: @devoncarew

devoncarew commented 7 years ago

Sorry for the delay! lgtm

devoncarew commented 7 years ago

Landed this, but local testing show a bunch of regressions re: our dart-js interop code...

devoncarew commented 7 years ago

(not related to this PR)