search

dart-atom / dart

A Dart plugin for Atom.
http://dart-atom.github.io/dart/
BSD 3-Clause "New" or "Revised" License
154 stars 44 forks source link

Lints no longer show up in IDE #1118

Closed jacehensley-wf closed 6 years ago

jacehensley-wf commented 7 years ago

After upgrading to Linter v2 infos, warnings, and errors are not showing up in the IDE. They still show up in the warning panel.

image

devoncarew commented 7 years ago

From looking over that blog post, it's likely that we have some API changes to deal with to work with the v2 of the linter -

jacehensley-wf commented 7 years ago

I'd be happy to help out if you point me in some general direction 😄

devoncarew commented 7 years ago

Great!

This file: https://github.com/dart-atom/dartlang/blob/master/lib/atom_linter.dart is our interface to the linter API. I suspect (but haven't checked) that this is where things may have broken.

We define our our UI for how to show lints (the errors view). It looks like the v2 linter has both a better UI than the v1 linter and a configurable one. So - a much more comprehensive bit of work - would probably involve removing our custom problems view. But just getting things back to working would be a good start :)