Use the Indie Linter V2 API

[jacehensley-wf]

Proposed solution for https://github.com/dart-atom/dartlang/issues/1118

Problem

With the recent upgrade to the linter package lints stopped showing up in the IDE.

Solution

• Use the Indie Linter V2 API

Notes

• This makes it so two lint panels exist. Should this be removed in a follow up PR?
• I keep getting a error when I views to a different dart file. I am not sure if this is something I did. Or if this is the same dart2js issue noted here

TypeError: this.obj.callMethod$2 is not a function
    at EventListener$3 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:49942:18)
    at undefined.EventListener$ (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:49948:14)
    at NavigationHelper.dart.NavigationHelper._activate$1 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:51939:33)
    at $constructor.<anonymous> (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:29979:32)
    at _RootZone.runUnaryGuarded$2 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:35064:20)
    at _BroadcastSubscription._sendData$1 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:34371:20)
    at _DelayedData.perform$1 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:34528:18)
    at _PendingEvents_schedule_closure.dart._PendingEvents_schedule_closure.call$0 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:34582:16)
    at undefined._microtaskLoop (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:32436:27)
    at $constructor.dart._startMicrotaskLoop (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:32442:11)
    at TimerImpl_internalCallback0.dart.TimerImpl_internalCallback0.call$0 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:29038:23)
    at invokeClosure_closure.call$0 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:30926:29)
    at _IsolateContext.eval$1 (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:28658:25)
    at undefined._callInIsolate (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:28302:28)
    at dart.invokeClosure (/Users/jacehensley/workspaces/dartlang/web/entry.dart.js:29879:20)
    at /Users/jacehensley/workspaces/dartlang/web/entry.dart.js:29900:18

Questions

• Should I rip out the existing self-API related things (what I deprecated)?
  • If I did this should probably go into a breaking change release, not sure if wanted that.

FYA: @devoncarew

[jacehensley-wf]

I'm thinking it might be for the best to just removed all the old stuff and release as 0.7.0.

Is there a way to make a minimum version requirement for package dependency? I was thinking this could also require at least 2.0.0 of linter.

[jacehensley-wf]

Looks like constraining to specific package deps version will be possible soon: https://github.com/steelbrain/package-deps/pull/86

Edit: That would require switching from required-packages to package-deps are you fine with that?

[Arcanemagus]

Just a note, the package-deps update coming out soon including that acts like a minimum version check. You can only specify exact versions to apm, so package-deps specifies exactly what you give it... but if a newer version is already installed it does nothing.

So a worse case scenario is you specify linter:2.0.0, apm installs that, and then immediately tells the user there is an update available.

[jacehensley-wf]

Okay, but a user can still update manually to the newer version right?

[steelbrain]

@jacehensley-wf That's correct!

[devoncarew]

@jacehensley-wf - thanks for the PR! I'm OOO for a few days but will take a look when I'm back.

[stwupton]

A friendly nudge :), any plans to merge this soon?

[jacehensley-wf]

This doesn't really work :( I have some work locally that rips out the pre-v2 linter stuff and nothing works. I need to sync with @devoncarew on some of this stuff.

[devoncarew]

@jacehensley-wf, thanks for this PR! It looks like @cdavidjean has a functioning implementation over in https://github.com/dart-atom/dartlang/pull/1135, so I'll close this one.

[jacehensley-wf]

👍