[Phase 2 - Tools] Update Atom plug-in to support Static Extension Methods

[ghost]

@aadilmaan commented on Aug 13, 2019, 9:02 PM UTC:

The Dart Atom plug-in has a grammar for syntax highlighting Dart code in Atom. This same grammar is also used for syntax highlighting on GitHub. Update this to handle the new syntax.

This issue was moved by devoncarew from dart-lang/sdk#37850.

[ghost]

@alexander-doroshko commented on Aug 29, 2019, 12:32 PM UTC:

@a-siva @devoncarew Probably area-intellij is not relevant here?

[ghost]

@a-siva commented on Aug 29, 2019, 4:20 PM UTC:

Agree, we don't seem to have any Atom specific label or a generic plugin label. Removed the area-intellij label, please feel free to assign it to some other area label.

[ghost]

@devoncarew commented on Aug 29, 2019, 5:40 PM UTC:

/move dart-atom/dart

[ghost]

move[bot] commented on Aug 29, 2019, 5:40 PM UTC:

⚠️ The [GitHub App](https://github.com/apps/move) must be installed for the target repository.

[DanTup]

@devoncarew I opened https://github.com/dart-atom/dart/pull/1194 with the keyword in the grammar.

There were some other changes we had to make in VS Code to map the new kind on completion items and outline items, as well as showing <unnamed extension> in the outline view for extensions with no name. I don't know if any of those are appropriate here (they're not required for correct syntax highlighting).

[devoncarew]

@devoncarew I opened #1194 with the keyword in the grammar.

Thanks!

There were some other changes we had to make in VS Code to map the new kind on completion items and outline items, as well as showing <unnamed extension> in the outline view for extensions with no name. I don't know if any of those are appropriate here (they're not required for correct syntax highlighting).

We're just maintaining the syntax highlighting file now, so I think those items likely don't apply.

[devoncarew]

fixed in https://github.com/dart-atom/dart/pull/1194