search

dart-bitcoin / bip32-dart

A BIP32 compatible library for Flutter writing by Dart.
MIT License
19 stars 33 forks source link

null safety upgrade #14

Closed jcramer closed 3 years ago

jcramer commented 3 years ago

Just wanted to help moving things along for this. I know there is another PR for null safety but there are conflicts and it may be getting stale. I did a quick upgrade from master and checked the tests are still passing.

It looks like vscode dart plugin thinks lines were getting too long, so it automatically did some linting to multi-lines in some cases. If this is undesirable, lmk and I'll try to revert it.

On a separate note, I noticed travis build hasn't been setup for this repo. Would be as simple as adding .travis.yml file with just language: dart.

SFzxc commented 3 years ago

Thanks @jcramer. Would you mind to become maintainer of https://github.com/dart-bitcoin/bitcoin_flutter

SFzxc commented 3 years ago

This cool PR is pre-step to resolved https://github.com/dart-bitcoin/bitcoin_flutter/issues/50. let me know if you're interesting, Thank for your contributing!

p3root commented 3 years ago

@SFzxc will look into it!