search

dart-bitcoin / bitcoin_flutter

A dart Bitcoin library for Flutter.
MIT License
165 stars 123 forks source link

Add support for optional 'noStrict' parameter in Transaction.fromBuffer #45

Closed ivaneidel closed 3 years ago

ivaneidel commented 4 years ago

We added this parameter to be able to return a transaction without failing due to offset check.

The motivation for this comes from the bitcoinjs library as shown in the following links:

longhoangwkm commented 4 years ago

Thanks for contributing, @ivaneidel! Could you check pub run test. 1 test case is failed now

brunocalmels commented 3 years ago

@ivaneidel it'd be really cool to have this merged. Could you manage to get tests passing?

ivaneidel commented 3 years ago

Hi there!

Sorry @longhoangwkm it took so long to make the fix and reply, but now it's fixed. The tests all pass and the parameter is always optional and false.

Let me know what you think!

Cheers!

longhoangwkm commented 3 years ago

LGTM, Thanks @ivaneidel

longhoangwkm commented 3 years ago

Released at 2.0.2 version https://pub.dev/packages/bitcoin_flutter/changelog