docgen problems

[adam-singer]

@devoncarew Not totally sure what is going on just yet. I have removed the docgen stuff from drone.io but looking at old logs it looks like drone was failing but reporting success.

https://drone.io/github.com/dart-gde/chrome.dart/236

I noticed also that dartdocs.org tries to build chrome.dart and also fails but for a different reason then drone.io.

http://www.dartdocs.org/buildlogs/b-10b87bcef436fb3df8ef07ce33b6a-startupscript.log

I filed a dartbug cause the VM triggers a stack overflow on both mac and linux.

https://code.google.com/p/dart/issues/detail?id=20740

Need to run some the drone_io.sh stuff by hand and see if I spot anything that is failing in general.

[devoncarew]

Hmm, I don't know why drone was failing to fail, but I fixed those 4 failing tests (a very recent regression).

[adam-singer]

Still fails, looks like some dart file was still included that does not exist

unittest-suite-success
+ dart bin/setup_app.dart app/demo demo.dart
copying packages/ to app/demo/packages/...
dart2js app/demo/demo.dart --out=app/demo/demo.dart.js
app/demo/packages/chrome/gen/context_menus.dart:10:8:
Error: Can't read 'package:chrome/gen/context_menus_internal.dart' (Error reading 'app/demo/packages/chrome/gen/context_menus_internal.dart' (OS Error: No such file or directory, errno = 2)).
import 'context_menus_internal.dart';
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Compilation failed.
Unhandled exception:
Exception: dart2js failed with a return code of 1
#0      runProcess (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:49:5)
#1      buildApp (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:27:13)
#2      Function.apply (dart:core-patch/function_patch.dart:28)
#3      FunctionScript._getTopCommandResult (package:unscripted/src/script_impl.dart:148:72)
#4      DeclarationScript._handleResults (package:unscripted/src/script_impl.dart:101:41)
#5      ScriptImpl.execute (package:unscripted/src/script_impl.dart:45:19)
#6      main (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:7:63)
#7      _startIsolate.isolateStartHandler (dart:isolate-patch/isolate_patch.dart:212)
#8      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:122)
+ dartanalyzer app/demo/demo.dart
Analyzing [app/demo/demo.dart]...
No issues found
+ dart bin/setup_app.dart app/test_app harness.dart
copying packages/ to app/test_app/packages/...
dart2js app/test_app/harness.dart --out=app/test_app/harness.dart.js
app/test_app/packages/chrome/gen/context_menus.dart:10:8:
Error: Can't read 'package:chrome/gen/context_menus_internal.dart' (Error reading 'app/test_app/packages/chrome/gen/context_menus_internal.dart' (OS Error: No such file or directory, errno = 2)).
import 'context_menus_internal.dart';
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Compilation failed.
Unhandled exception:
Exception: dart2js failed with a return code of 1
#0      runProcess (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:49:5)
#1      buildApp (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:27:13)
#2      Function.apply (dart:core-patch/function_patch.dart:28)
#3      FunctionScript._getTopCommandResult (package:unscripted/src/script_impl.dart:148:72)
#4      DeclarationScript._handleResults (package:unscripted/src/script_impl.dart:101:41)
#5      ScriptImpl.execute (package:unscripted/src/script_impl.dart:45:19)
#6      main (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:7:63)
#7      _startIsolate.isolateStartHandler (dart:isolate-patch/isolate_patch.dart:212)
#8      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:122)
+ dartanalyzer app/test_app/harness.dart
Analyzing [app/test_app/harness.dart]...
No issues found
+ dart bin/setup_app.dart app/test_ext harness.dart
copying packages/ to app/test_ext/packages/...
dart2js app/test_ext/harness.dart --out=app/test_ext/harness.dart.js
app/test_ext/packages/chrome/gen/context_menus.dart:10:8:
Error: Can't read 'package:chrome/gen/context_menus_internal.dart' (Error reading 'app/test_ext/packages/chrome/gen/context_menus_internal.dart' (OS Error: No such file or directory, errno = 2)).
import 'context_menus_internal.dart';
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Compilation failed.
Unhandled exception:
Exception: dart2js failed with a return code of 1
#0      runProcess (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:49:5)
#1      buildApp (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:27:13)
#2      Function.apply (dart:core-patch/function_patch.dart:28)
#3      FunctionScript._getTopCommandResult (package:unscripted/src/script_impl.dart:148:72)
#4      DeclarationScript._handleResults (package:unscripted/src/script_impl.dart:101:41)
#5      ScriptImpl.execute (package:unscripted/src/script_impl.dart:45:19)
#6      main (file:///home/ubuntu/src/github.com/dart-gde/chrome.dart/bin/setup_app.dart:7:63)
#7      _startIsolate.isolateStartHandler (dart:isolate-patch/isolate_patch.dart:212)
#8      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:122)
+ dartanalyzer app/test_ext/harness.dart
Analyzing [app/test_ext/harness.dart]...
No issues found

[adam-singer]

I wonder if drone is not cleaning out the files on each run. Could be leftovers from setting up the app directory

[adam-singer]

Actually this line in the drone_io.sh script is failing us. We re-gen all the apis, last re-gen you had to hand patch some files correct?

# generate the APIs; ensure the gen tool is happy
dart tool/gen_apis.dart

[devoncarew]

Ah, yeah. I'd forgotten. Perhaps we should comment that line out with an associated bug? We can depend on the checked in source for now.

[adam-singer]

sgtm, i'll send that down the pipe