search

dart-gde / chrome_gen.dart

Deprecated! See dart-gde/chrome.dart
https://github.com/dart-gde/chrome.dart
Other
6 stars 6 forks source link

fix to file moveTo(), copyTo() #120

Closed devoncarew closed 10 years ago

devoncarew commented 10 years ago

Fix a copy and paste issue with Entry.copyTo() and Entry.MoveTo(). @keertip

@financeCoding Adam, we'd like to consume this fix. That means pushing out a new version; your recent CL changed some APIs. What do you think about a full point release (0.2.3-dev ==> 0.3.0)?

adam-singer commented 10 years ago

Lgtm. A release of 0.3.0 sounds right. I have not had time to give some tests to the generated APIs so hopefully it does not fully break anyone. BTW could you add me as an uploader to chrome_gen on pub.

devoncarew commented 10 years ago

It looks like you're already an uploader. Do you want to do the 0.3.0 push?

adam-singer commented 10 years ago

You can push, I just didn't know if I was able to for next time

devoncarew commented 10 years ago

Cool, done.

@keertip, chrome_gen 0.3.0 contains the fix to the moveTo and copyTo methods.

keertip commented 10 years ago

Thanks! Will upgrade.