jakemac53
commented
4 years ago
- If possible, show the line that imports this dependency, specially if the line is in the current project/package.
- Show in the warning the exactly dependency with problems.
It should be listing the libraries that had the non-browser dependencies - if it isn't and you have a reproduction case we can look at that would be great.
- webdev serve using cached builds, needs to show, again, the warning, informing a skipped entrypoint.
We only show errors on subsequent builds, not warnings (the warning was a part of a cached build action). We could consider adding an option to upgrade this to a Severe log, which would make the entire build fail but it would show you the error on each build. Would that help?
(Error logs are cached and re-logged even if the action itself is not re-ran)
We could also consider similarly caching and re-logging warnings. cc @natebosch for thoughts on that.
- An extra suggestion is a command pub get -clean and a webdev build/serve -clean (you got the idea). Many build frameworks in the past, have the clean option, to ensure that caches are being removed (for decades this saved many developers).
There is a clean command in build_runner (which webdev is using under the covers). You can do pub run build_runner clean to have it clean things up. We should probably add a clean command to webdev too though. cc @grouma @kevmoo any reason we haven't done that?
natebosch
grouma
jodinathan
The Issue
While compiling a Web project that have some dependency or code like
dart:io(or any non browser compatible dependency), build will show a warning:After this warning is IMPOSSIBLE to correctly investigate what transitive dependency is responsible for that.
If some developer wrongly imports
dart:io, you won't find it! Onlygitcan help you, to find the changed line.If this happens in a 3rd part code you are totally lost (imagine a package that you just upgraded).
For me this is a SEVERE issue, since you are in dead zone and can't make any progress.
Also future builds won't show the warning message, only shows a normal start of
webdev serve:Looks like a normal start of a
webdev serve, but you won't find anything athttp://0.0.0.0:8080, only a 404 response.Note that even restarting
webdevprocess, it won't inform a skippedentrypoint. The only possible way is to force rebuild, removing directory.dart_tooland performing againpub get.So, to fix it, you need to be in a paranoid mode, to try to remove
.dart_tool, executepub devand than startwebdev serveagain to understand what is happening.Sugested Fix
Show in the warning the exactly dependency with problems.
If possible, show the line that imports this dependency, specially if the line is in the current project/package.
webdev serveusing cached builds, needs to show, again, the warning, informing a skipped entrypoint.An extra suggestion is a command
pub get -cleanand awebdev build/serve -clean(you got the idea). Many build frameworks in the past, have thecleanoption, to ensure that caches are being removed (for decades this saved many developers).Environment
Dart VM version: 2.8.3 (stable) (Tue May 26 18:39:38 2020 +0200) on "macos_x64"
build_runner 1.10.0