search

dart-lang / build

A build system for Dart written in Dart
https://pub.dev/packages/build
BSD 3-Clause "New" or "Revised" License
791 stars 211 forks source link

Use the 'dart compile js-dev' command for invoking DDC … #3768

Open a-siva opened 3 weeks ago

a-siva commented 3 weeks ago

Use the 'dart compile js-dev' command for invoking DDC instead of reaching into the dart-sdk and using the snapshot which is an internal implementation detail of the dart sdk.

github-actions[bot] commented 3 weeks ago

PR Health

Changelog Entry :heavy_check_mark: | Package | Changed Files | | :--- | :--- | Changes to files need to be [accounted for](https://github.com/dart-lang/ecosystem/wiki/Changelog) in their respective changelogs.
jakemac53 commented 3 weeks ago

Once we have a released dev SDK to depend on, I can update the CI jobs etc and push that here.

jakemac53 commented 3 weeks ago

cc @a-siva @nshahan something seems to be broken with the dart compile js-dev command on windows? I am not getting a lot of useful information from the GitHub logs though.

a-siva commented 3 weeks ago

cc @a-siva @nshahan something seems to be broken with the dart compile js-dev command on windows? I am not getting a lot of useful information from the GitHub logs though.

Will investigate, looks like tests are waiting for temp directories to get deleted but they are in use, could be a test issue.

jakemac53 commented 3 weeks ago

Will investigate, looks like tests are waiting for temp directories to get deleted but they are in use, could be a test issue.

I think that possibly the worker isn't shutting down like it normally would.

jakemac53 commented 3 weeks ago

Note that we just send it a sigterm by calling Process.kill. I don't know how the dart tool deals with that, and if it can handle shutting down its sub-processes etc.

a-siva commented 3 weeks ago

Note that we just send it a sigterm by calling Process.kill. I don't know how the dart tool deals with that, and if it can handle shutting down its sub-processes etc.

It does not handle shutting down sub-processes, if that is the issue we should also see errors on other platforms (linux, mac)

jakemac53 commented 2 weeks ago

It does not handle shutting down sub-processes, if that is the issue we should also see errors on other platforms (linux, mac)

Well, only windows won't allow deleting a directory because some sub-process has file handles in that directory still open. So it is possible that is the only reason we don't see the error on other platforms. If the process is left dangling though that is of course bad.