search

dart-lang / characters

A package for characters represented as unicode extended grapheme clusters
https://pub.dev/packages/characters
BSD 3-Clause "New" or "Revised" License
69 stars 17 forks source link

Updated to latest Unicode spec 15.1.0 and set version to 1.4.0 #95

Closed erf closed 5 months ago

erf commented 8 months ago

I ran tool/generate.dart to update to the latest Unicode spec 15.1.0.

I ran tests and benchmarks OK.

I set the CHANGELOG.md and pubspec.yaml to version 1.4.0

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

kevmoo commented 8 months ago

@lrhn – wanna take a look?

lrhn commented 8 months ago

I don't think this update is needed.

While Unicode 15.1 introduces new emoji combinations, it does that by assigning a meaning to combinations that can already be made today. It doesn't change how to break the text into grapheme clusters.

If there is no difference between Unicode 15.0 and Unicode 15.1 in the grapheme cluster segmentation, it means there is no difference in the generated tables, which is also what we see. That means that there is no functional change, and no need to change anything. All this PR does is change "15.0.0" to "latest" in a comment, which isn't really an improvement (I should try to make it write the actual number instead of current), and reformats the generated test file, which seems to show a difference in dart format, not content.

erf commented 8 months ago

I see. Feel free to close.