search

dart-lang / code_builder

A fluent API for generating valid Dart source code
https://pub.dev/packages/code_builder
BSD 3-Clause "New" or "Revised" License
427 stars 66 forks source link

print type parameters in typedefs #403

Closed jodinathan closed 1 year ago

jodinathan commented 1 year ago

fixes https://github.com/dart-lang/code_builder/issues/402

donny-dont commented 1 year ago

I feel like the formatting parts from this PR should be removed and done in another PR.

jodinathan commented 1 year ago

@donny-dont even thought I followed the instructions in the README about formatting, I think the changes happened when I executed the generator.
I mean, I am not sure if I can separate them without manually touching the source generated files

donny-dont commented 1 year ago

@jodinathan I did #404 in case the maintainers here wanted a commit for just updating the generated files. It seems to have a majority of the stuff you had in your commit.

jodinathan commented 1 year ago

So what should I do? :D

donny-dont commented 1 year ago

@jodinathan the changes are in just rebase your patch. If it has any problems during the rebase just fix the conflicts or default to the base branch and rerun the generation.

donny-dont commented 1 year ago

Its saved as a .txt file but here's a diff with your changes based on latest master.

typedef.txt