dart-lang / code_builder

A fluent API for generating valid Dart source code
https://pub.dev/packages/code_builder
BSD 3-Clause "New" or "Revised" License
423 stars 66 forks source link

Testing only code (ie: matchers) should be exported through a specific library #405

Open jakemac53 opened 1 year ago

jakemac53 commented 1 year ago

See https://github.com/dart-lang/code_builder/blob/master/lib/src/matchers.dart#L5.

This causes problems internally because it prevents matcher from being a testonly target, which it should be. It also means matcher is a transitive dep of anything that depends on code_builder, which should not be the case.

This would probably have to be a breaking change though.

devoncarew commented 1 month ago

To follow up on this, of the top 200 packages that depend on this package from pub, here are the ones that reference the symbol equalsDart:

references to equalsDart:

references to equalsDart: