Class modifiers - Githubissues

dart-lang / code_builder

A fluent API for generating valid Dart source code

https://pub.dev/packages/code_builder

BSD 3-Clause "New" or "Revised" License

423 stars 66 forks source link

Class modifiers #414

Closed dnys1 closed 1 year ago

dnys1 commented 1 year ago

An attempt at adding class modifiers in a non-breaking way.

Outstanding questions:

Is the validation and/or API enough to encourage proper use?
Are the tests sufficient for the changes?

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Many Dart repos have a weekly cadence for reviewing PRs - please allow for a week or two of latency for initial review feedback.

kevmoo commented 1 year ago

I think someone on the google side needs to land this...