Closed mosuem closed 9 months ago
github-actions[bot]
commented
9 months ago | Package | Version | Status | Publish tag (post-merge) |
|---|---|---|---|
| package:code_builder | 4.7.0 | ready to publish | v4.7.0 |
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.
natebosch
commented
9 months ago What was the motivation for this?
I don't specifically disagree with the change - but I'm just now noticing the impact as I'm trying to roll it in to google3. Is it worth breaking existing golden tests for this change?
natebosch
commented
9 months ago Followed the backlink to https://github.com/dart-lang/i18n/pull/721#discussion_r1331939944
I do think the change makes sense. I'll work on the golden files.
Add a newline after lambdas.
Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.